Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Containerfile.operator files in preparation to move to RHTAP #102

Merged

Conversation

subbarao-meduri
Copy link

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Verification

Signed-off-by: Subbarao Meduri <smeduri@redhat.com>
@openshift-ci openshift-ci bot added the approved label May 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@subbarao-meduri how will we maintain this Makefile? What do we have to do when it diverges from upstream? Can we not duplicate everything but only extend the make targets that we need?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@douglascamata I re-did the new Makefile targets to only override specific targets while including original Makefile. This should make it easier to maintain. Please review.

Signed-off-by: Subbarao Meduri <smeduri@redhat.com>
Copy link

@douglascamata douglascamata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 8, 2024
Copy link

openshift-ci bot commented May 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: douglascamata, subbarao-meduri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [douglascamata,subbarao-meduri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@subbarao-meduri subbarao-meduri merged commit 750a2ed into stolostron:release-2.11 May 8, 2024
12 of 14 checks passed
@subbarao-meduri subbarao-meduri deleted the rhtap-prep-211 branch May 8, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants